Re: [PATCH] scripts/min-tool-version.sh: Raise minimum clang version to 13.0.0 for s390

From: Masahiro Yamada
Date: Fri Jun 18 2021 - 20:41:53 EST


On Fri, Jun 18, 2021 at 5:42 PM Heiko Carstens <hca@xxxxxxxxxxxxx> wrote:
>
> On Thu, Jun 17, 2021 at 12:31:40PM -0700, Nathan Chancellor wrote:
> > clang versions prior to the current development version of 13.0.0 cannot
> > compile s390 after commit 3abbdfde5a65 ("s390/bitops: use register pair
> > instead of register asm") and the s390 maintainers do not intend to work
> > around this in the kernel. Codify this in scripts/min-tool-version.sh
> > similar to arm64 with GCC 5.1.0 so that there are no reports of broken
> > builds.
> >
> > Reported-by: Naresh Kamboju <naresh.kamboju@xxxxxxxxxx>
> > Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> > ---
> >
> > This should probably go through the s390 tree with Masahiro's ack.

Acked-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>


> Thank's a lot!
>
> I'll add the below text to the commit message, and apply it internally
> first:
>
> [hca@xxxxxxxxxxxxx: breaking compatibility with older clang compilers
> is intended to finally make use of a feature which allows the
> compiler to allocate even/odd register pairs. This is possible since
> a very long time with gcc, but only since llvm-project commit
> d058262b1471 ("[SystemZ] Support i128 inline asm operands.") with
> clang. Using that feature allows to get rid of error prone register
> asm statements, of which the above named kernel commit is only the
> first of a larger not yet complete series]
>
> --
> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@xxxxxxxxxxxxxxxx.
> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/YMxcdv/1taBevSjP%40osiris.



--
Best Regards
Masahiro Yamada