Re: [PATCH] mlx4_core: Remove trailing semicolon in macros

[Tariq Toukan]

On 6/20/2021 5:36 PM, Huilong Deng wrote:
> Macros should not use a trailing semicolon.
>
> Signed-off-by: Huilong Deng <denghuilong@xxxxxxxxxx>
> ---
>   include/linux/mlx4/doorbell.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mlx4/doorbell.h b/include/linux/mlx4/doorbell.h
> index f31bba270aa2..e3ecaa4f00fa 100644
> --- a/include/linux/mlx4/doorbell.h
> +++ b/include/linux/mlx4/doorbell.h
> @@ -66,7 +66,7 @@ static inline void mlx4_write64(__be32 val[2], void __iomem *dest,
>    * MMIO writes.
>    */
>   
> -#define MLX4_DECLARE_DOORBELL_LOCK(name) spinlock_t name;
> +#define MLX4_DECLARE_DOORBELL_LOCK(name) spinlock_t name
>   #define MLX4_INIT_DOORBELL_LOCK(ptr)     spin_lock_init(ptr)
>   #define MLX4_GET_DOORBELL_LOCK(ptr)      (ptr)
>   

Reviewed-by: Tariq Toukan <tariqt@xxxxxxxxxx>

Thanks,
Tariq