Re: Re: [PATCH] drivers/nvme/host: Use kobj_to_dev() API
From: Keith Busch
Date: Sun Jun 20 2021 - 13:28:14 EST
On Sat, Jun 19, 2021 at 01:01:34PM +0800, 周传高 wrote:
> >On Fri, Jun 18, 2021 at 07:10:58AM -0700, zhouchuangao wrote:
> >> Use kobj_to_dev() API instead of container_of().
> >
> >Why? That just makes the code harder to read.
>
> In my opinion, the kobj_to_dev() interface is provided by the kernel so that
> we can get device based on kobj without having to pass more parameters.
> I think it's easier to use.
This same patch has been proposed and rejected numerous times. Do we
need to place a comment in the code to prevent future requests?
http://lists.infradead.org/pipermail/linux-nvme/2021-March/023316.html
http://lists.infradead.org/pipermail/linux-nvme/2021-February/023060.html
http://lists.infradead.org/pipermail/linux-nvme/2020-September/019462.html