Re: [PATCH -next 3/4] ASoC: samsung: s3c2412-i2s: Use devm_platform_get_and_ioremap_resource()

From: Krzysztof Kozlowski
Date: Mon Jun 21 2021 - 05:22:41 EST


On 16/06/2021 11:16, Yang Yingliang wrote:
> Use devm_platform_get_and_ioremap_resource() to simplify
> code.
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> ---
> sound/soc/samsung/s3c2412-i2s.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/soc/samsung/s3c2412-i2s.c b/sound/soc/samsung/s3c2412-i2s.c
> index 81f416ac457e..ec1c6f9d76ac 100644
> --- a/sound/soc/samsung/s3c2412-i2s.c
> +++ b/sound/soc/samsung/s3c2412-i2s.c
> @@ -208,8 +208,7 @@ static int s3c2412_iis_dev_probe(struct platform_device *pdev)
> return -ENXIO;
> }
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - s3c2412_i2s.regs = devm_ioremap_resource(&pdev->dev, res);
> + s3c2412_i2s.regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(s3c2412_i2s.regs))
> return PTR_ERR(s3c2412_i2s.regs);
>
>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>

Best regards,
Krzysztof