Re: [PATCH V4 10/12] trace: Add osnoise tracer

[Daniel Bristot de Oliveira]

On 6/18/21 7:55 PM, Steven Rostedt wrote:
> On Tue, 15 Jun 2021 11:28:49 +0200
> Daniel Bristot de Oliveira <bristot@xxxxxxxxxx> wrote:
> 
>> diff --git a/arch/x86/kernel/trace.c b/arch/x86/kernel/trace.c
>> new file mode 100644
>> index 000000000000..e67d63657628
>> --- /dev/null
>> +++ b/arch/x86/kernel/trace.c
>> @@ -0,0 +1,238 @@
>> +#include <asm/trace/irq_vectors.h>
>> +
>> +#ifdef CONFIG_OSNOISE_TRACER
>> +extern void osnoise_trace_irq_entry(int id);
>> +extern void osnoise_trace_irq_exit(int id, const char *desc);
> Any reason to have the above outside the LOCAL_APIC def?

no...

It's not used.
> In fact, this could just be turned into:
> 
> #if defined(CONFIG_OSNOISE_TRAECR) && defined(CONFIG_X86_LOCAL_APIC)

I will do that!

-- Daniel

> -- Steve
> 
> 
>> +
>> +#ifdef CONFIG_X86_LOCAL_APIC
> [..]
>