Re: [RFC 01/19] staging: qlge: fix incorrect truesize accounting

From: Dan Carpenter
Date: Mon Jun 21 2021 - 10:10:53 EST


On Mon, Jun 21, 2021 at 09:48:44PM +0800, Coiby Xu wrote:
> Commit 7c734359d3504c869132166d159c7f0649f0ab34 ("qlge: Size RX buffers
> based on MTU") introduced page_chunk structure. We should add
> qdev->lbq_buf_size to skb->truesize after __skb_fill_page_desc.
>

Add a Fixes tag.

The runtime impact of this is just that ethtool will report things
incorrectly, right? It's not 100% from the commit message. Could you
please edit the commit message so that an ignoramous like myself can
understand it?

Why is this an RFC instead of just a normal patch which we can apply?

regards,
dan carpenter