Re: [patch V3 30/66] x86/fpu: Rename fregs related copy functions

[Borislav Petkov]

On Fri, Jun 18, 2021 at 04:18:53PM +0200, Thomas Gleixner wrote:
> The function names for fnsave/fnrstor operations are horribly named and
> a permanent source of confusion.
> 
> Rename:
> 	copy_fregs_to_kernel() to fnsave()

That first one is not existant.

> 	copy_kernel_to_fregs() to fnrstor()

				frstor() - no "n"

> 	copy_fregs_to_user()   to fnsave_to_user_sigframe()
> 	copy_user_to_fregs()   to fnrstor_from_user_sigframe()
> 
> so it's clear what these are doing. All these functions are really low
> level wrappers around the equaly named instructions, so mapping to the
> documentation is just natural.
> 
> No functional change.
> 
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> ---
> V3: Rename (Boris)
> ---
>  arch/x86/include/asm/fpu/internal.h |   10 +++++-----
>  arch/x86/kernel/fpu/core.c          |    2 +-
>  arch/x86/kernel/fpu/signal.c        |    6 +++---
>  3 files changed, 9 insertions(+), 9 deletions(-)

Regardless, above is just nitpicks.

Reviewed-by: Borislav Petkov <bp@xxxxxxx>

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg