RE: [net-next, v3, 05/10] ethtool: add a new command for getting PHC virtual clocks

[Y.b. Lu]

Hi Michal,

> -----Original Message-----
> From: Michal Kubecek <mkubecek@xxxxxxx>
> Sent: 2021年6月16日 7:25
> To: Y.b. Lu <yangbo.lu@xxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-kselftest@xxxxxxxxxxxxxxx; mptcp@xxxxxxxxxxxxxxx; Richard Cochran
> <richardcochran@xxxxxxxxx>; David S . Miller <davem@xxxxxxxxxxxxx>;
> Jakub Kicinski <kuba@xxxxxxxxxx>; Mat Martineau
> <mathew.j.martineau@xxxxxxxxxxxxxxx>; Matthieu Baerts
> <matthieu.baerts@xxxxxxxxxxxx>; Shuah Khan <shuah@xxxxxxxxxx>; Florian
> Fainelli <f.fainelli@xxxxxxxxx>; Andrew Lunn <andrew@xxxxxxx>; Rui Sousa
> <rui.sousa@xxxxxxx>; Sebastien Laveze <sebastien.laveze@xxxxxxx>
> Subject: Re: [net-next, v3, 05/10] ethtool: add a new command for getting PHC
> virtual clocks
> 
> On Tue, Jun 15, 2021 at 05:45:12PM +0800, Yangbo Lu wrote:
> > Add an interface for getting PHC (PTP Hardware Clock) virtual clocks,
> > which are based on PHC physical clock providing hardware timestamp to
> > network packets.
> >
> > Signed-off-by: Yangbo Lu <yangbo.lu@xxxxxxx>
> > ---
> > Changes for v3:
> > 	- Added this patch.
> > ---
> >  include/linux/ethtool.h              |  2 +
> >  include/uapi/linux/ethtool.h         | 14 +++++
> >  include/uapi/linux/ethtool_netlink.h | 15 +++++
> >  net/ethtool/Makefile                 |  2 +-
> >  net/ethtool/common.c                 | 23 ++++++++
> >  net/ethtool/common.h                 |  2 +
> >  net/ethtool/ioctl.c                  | 27 +++++++++
> >  net/ethtool/netlink.c                | 10 ++++
> >  net/ethtool/netlink.h                |  2 +
> >  net/ethtool/phc_vclocks.c            | 86
> ++++++++++++++++++++++++++++
> >  10 files changed, 182 insertions(+), 1 deletion(-)  create mode
> > 100644 net/ethtool/phc_vclocks.c
> 
> When updating the ethtool netlink API, please update also its documentation
> in Documentation/networking/ethtool-netlink.rst

Will update doc. Thank you.

> 
> Michal