Re: [PATCH v4 2/3] dt-bindings: serial: Convert Cortina-Access UART to json-schema

[Geert Uytterhoeven]

On Tue, Jun 15, 2021 at 6:21 PM Rob Herring <robh+dt@xxxxxxxxxx> wrote:
> On Tue, Jun 15, 2021 at 10:06 AM Alex Nemirovsky
> <Alex.Nemirovsky@xxxxxxxxxxxxxxxxxx> wrote:
> > > On Jun 15, 2021, at 8:44 AM, Rob Herring <robh+dt@xxxxxxxxxx> wrote:
> > > On Tue, Jun 15, 2021 at 8:39 AM Alex Nemirovsky
> > > <Alex.Nemirovsky@xxxxxxxxxxxxxxxxxx> wrote:
> > >>
> > >>
> > >>
> > >>> On Jun 15, 2021, at 7:13 AM, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > >>>
> > >>> On Tue, Jun 15, 2021 at 01:36:39PM +0000, Alex Nemirovsky wrote:
> > >>>> MAINTAINERS modification was made in the initial version 1.  We made no changes to it since then,
> > >>>> thus not sure what we could at to  Changelog which would add value or clarity for others
> > >>>> from the v1.
> > >>>>
> > >>>>> On Jun 15, 2021, at 4:53 AM, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > >>>>>
> > >>>>> On Sun, May 09, 2021 at 11:45:17AM -0700, Alex Nemirovsky wrote:
> > >>>>>> From: Jason Li <jason.li@xxxxxxxxxxxxxxxxxx>
> > >>>>>>
> > >>>>>> Convert the Cortina-Access UART binding to DT schema format.
> > >>>>>>
> > >>>>>> Signed-off-by: Jason Li <jason.li@xxxxxxxxxxxxxxxxxx>
> > >>>>>> ---
> > >>>>>> .../serial/cortina-access,serial.yaml         | 46 +++++++++++++++++++
> > >>>>>> .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
> > >>>>>> MAINTAINERS                                   |  6 +++
> > >>>>>
> > >>>>> You are also adding a MAINTAINERS entry here, which is not listed in the
> > >>>>> changelog text, so I couldn't take it anyway :(
> > >>>
> > >>> Add the maintainers entry in the first patch, with the driver please.
> > >>
> > >> The change to MAINTAINERS here add a new file into the DT documentation.
> > >> Should it not be grouped into the dt-binding portion and reviewed by the DT time for which this patch
> > >> is CC’ed to? Why would moving the DT documentation file that is introduced be into the first patch, which is the
> > >> serial driver itself be the correct approach?
> > >
> > > The binding doesn't actually need a MAINTAINERS entry (though having
> > > one is fine). get_maintainers.pl will also pull emails from the
> > > binding schema.
> > >
> > > Rob
> >
> > Hi Rob,
> > It sounds like you are find with patch 2/3 from a DT point of view.  Could we review the rest from the DT point of view
> > to get either feedback for changes or ACK these, so we can unblock this series?
>
> Can't say I've seen it as I only see replies in my mail. Did this
> originally go to the DT list? If not, it's never in my queue[1].
>
> Rob
>
> [1] https://patchwork.ozlabs.org/project/devicetree-bindings/list/

None of the patches in this series ended up on a mailing list or on
lore, so no one could comment on them, except for people CCed directly.

The driver has been accepted in tty-next, commit b61c8bf4694b5115
("tty: serial: Add UART driver for Cortina-Access platform").  From a
quick glance, it could have used some review.

The driver is using the compatible value "cortina-access,serial", so I
guess the binding patch added "cortina-access" to vendor-prefixes.yaml.
According to https://www.cortina-access.com/news-and-events, this is
the same company as Cortina Systems, which already has the "cortina"
vendor prefix.  In 2015, it was acquired by Realtek, so perhaps it
should use the "realtek" prefix instead for new development?

The SERIAL_CORTINA_ACCESS symbol doesn't depend on anything, so
it will show up on everyone's oldconfig radar soon, regardless of
building a kernel for a Cortina Access system or not.
I wanted to change it to something like:

     config SERIAL_CORTINA_ACCESS
            tristate "Cortina-Access serial port support"
    +       depends on FIXME || COMPILE_TEST
            select SERIAL_CORE
            help
              This driver is for Cortina-Access SoC's UART. If you
have a machine
              based on the Cortina-Access SoC and wish to use the serial port,
              say 'Y' here. Otherwise, say 'N'.

but given there is no evidence of patches to add support for the
CAXXXX line of SoCs, there's no symbol to depend on...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds