Re: [syzbot] possible deadlock in ovl_maybe_copy_up

From: Mimi Zohar
Date: Tue Jun 22 2021 - 07:41:03 EST


> > Should annotating the iint be limited to files on overlay filesystems?
> >
>
> Not to overlay files specifically but to files on stacked fs,
> i.e. (inode->i_sb->s_stack_depth > 0)
> Assuming that this patch is tested(?), how come it did not hit the
> WARN_ON_ONCE(depth < 0... above?

Thanks, Amir!

As per the overlayfs comment, the depth can never be 0. It sounds like
in this case we only want to annotate the iint mutex for regular files,
if the stacking depth is greater than 0, but less than the max depth.

(I'm still trying to reproduce the lockdep.)

Mimi