Re: [PATCH] ARM: dts: at91: sama5d4_xplained: Mark optional AT25DF321A as disabled

[Nicolas Ferre]

Hi Tudor,

On 22/06/2021 at 15:42, Tudor Ambarus wrote:
> sama5d4_xplained has an optional on-board serial DataFlash (AT25DF321A),
> which does not come populated on board by default. Mark it as disabled
> to avoid the following probe error:
> spi-nor spi0.0: unrecognized JEDEC id bytes: 00 00 00 00 00 00
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>
> ---
>   arch/arm/boot/dts/at91-sama5d4_xplained.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> index 0b3ad1b580b8..f397e2a68e5c 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> @@ -40,7 +40,7 @@ uart0: serial@f8004000 {
>   
>   			spi0: spi@f8010000 {
>   				cs-gpios = <&pioC 3 0>, <0>, <0>, <0>;
> -				status = "okay";
> +				status = "disabled";
>   				m25p80@0 {
>   					compatible = "atmel,at25df321a";
>   					spi-max-frequency = <50000000>;

What about keeping SPI enabled and just having the status of m25p80 as 
disabled: honestly, I don't know if it works and if it's desirable, but 
might be closer to reality.

Tell me what you think.

Regards,
  Nicolas


--
Nicolas Ferre