Re: [PATH 3/4] dt-bindings: display: Add virtual DRM

From: Rob Herring
Date: Tue Jun 22 2021 - 12:55:05 EST


On Mon, Jun 21, 2021 at 03:44:02PM +0900, Tomohito Esaki wrote:
> Add device tree bindings documentation for virtual DRM.

DRM is a Linuxism. What's virtual DRM? Why does it need to be in DT?
What's the usecase? You're going to need a lot more reasoning to justify
this for DT.

>
> Signed-off-by: Tomohito Esaki <etom@xxxxxxxxxx>
> ---
> .../devicetree/bindings/display/vdrm.yaml | 67 +++++++++++++++++++
> 1 file changed, 67 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/vdrm.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/vdrm.yaml b/Documentation/devicetree/bindings/display/vdrm.yaml
> new file mode 100644
> index 000000000000..6493bb0fc09f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/vdrm.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/vdrm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Virtual DRM Device Tree Bindings
> +
> +description:
> + This document defines device tree properties virtual DRM. The initial
> + position, size and z-position of the plane used in the virtual DRM is
> + specified.
> + The current limitation is that these settings are applied to all crtc.
> +
> +properties:
> + compatible:
> + const: virt-drm
> +
> +patternProperties:
> + "^plane(@.*)?$":
> + description: Information of the planes used in virtual DRM
> + type: object
> +
> + properties:
> + x:
> + type: int
> + description: x-coordinate of the left-top of the plane in pixels
> +
> + y:
> + type: int
> + description: y-coordinate of the left-top of the plane in pixels
> +
> + width:
> + type: int
> + description: width of the plane in pixels
> +
> + height:
> + type: int
> + description: height of the plane in pixels
> +
> + zpos:
> + type: int
> + description: z-position of the plane
> +
> + required:
> + - x
> + - y
> + - width
> + - height
> + - zpos
> +
> +required:
> + - compatible
> + - "^plane(@.*)?$"
> +
> +examples:
> + - |
> + vdrm@0 {
> + compatible = "virt-drm";
> + plane@0 {
> + x = <200>;
> + y = <100>;
> + width = <800>;
> + height = <600>;
> + zpos = <1>;
> + };
> + };
> --
> 2.25.1
>
>