Re: [patch V3 55/66] x86/fpu: Remove PKRU handling from switch_fpu_finish()

From: Borislav Petkov
Date: Tue Jun 22 2021 - 13:08:56 EST


On Fri, Jun 18, 2021 at 04:19:18PM +0200, Thomas Gleixner wrote:
> PKRU is already updated and the xstate is not longer the proper source of
> information.
>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> ---
> arch/x86/include/asm/fpu/internal.h | 34 ++++------------------------------
> 1 file changed, 4 insertions(+), 30 deletions(-)
>
> --- a/arch/x86/include/asm/fpu/internal.h
> +++ b/arch/x86/include/asm/fpu/internal.h
> @@ -549,39 +549,13 @@ static inline void switch_fpu_prepare(st
> */
>
> /*
> - * Load PKRU from the FPU context if available. Delay loading of the
> - * complete FPU state until the return to userland.
> + * Delay loading of the complete FPU state until the return to userland.
> + * PKRU is handled seperately.

separately

With that fixed:

Reviewed-by: Borislav Petkov <bp@xxxxxxx>

--
Regards/Gruss,
Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg