Re: [PATCH v3 4/8] media: Add P010 video format

[Ezequiel Garcia]

On Tue, 2021-06-22 at 17:24 -0400, Nicolas Dufresne wrote:
> Le vendredi 18 juin 2021 à 16:38 -0300, Ezequiel Garcia a écrit :
> > Hi Benjamin,
> > 
> > On Fri, 2021-06-18 at 15:15 +0200, Benjamin Gaignard wrote:
> > > P010 is a YUV format with 10-bits per pixel with interleaved UV.
> > > 
> > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxxxxx>
> > > ---
> > > version 2:
> > >  - Add documentation about P010 padding
> > >  - Fix the number of bits per component (16)
> > > 
> > >  .../media/v4l/pixfmt-yuv-planar.rst           | 78 ++++++++++++++++++-
> > >  drivers/media/v4l2-core/v4l2-common.c         |  1 +
> > >  drivers/media/v4l2-core/v4l2-ioctl.c          |  1 +
> > >  include/uapi/linux/videodev2.h                |  1 +
> > >  4 files changed, 79 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst b/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst
> > > index 090c091affd2..af400d37c8fd 100644
> > > --- a/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst
> > > +++ b/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst
> > > @@ -100,8 +100,13 @@ All components are stored with the same number of bits per component.
> > >        - Cb, Cr
> > >        - No
> > >        - 64x32 macroblocks
> > > -
> > > -        Horizontal Z order
> > > +    * - V4L2_PIX_FMT_P010
> > 
> > Do we have support in GStreamer (or elsewhere) for this?
> 
> I believe you wanted to ask for patched framework to exercise this ? Since both
> FFMPEG and GSTreamer have had that format for ages. For GStreamer:
> 
> https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/blob/master/gst-libs/gst/video/video-format.h#L102
> 

Ah, great. This sort of info really could be in the commit description
as it's not always clear if a new pixel format looks sane or not.

> No V4L2 mapping upstream, but this is a bit normal, can't upstream a mapping for
> something that does not exist yet.
> 

Well, if you are happy with the patch as-is could you ack it? IIRC, Hantro
and VC8000D produce this, so we'll use it sooner or later. (This information
could be in the commit description as well).
-- 
Kindly,
Ezequiel