Re: [PATCH v2 14/46] mm/memcg: Add folio_charge_cgroup()

From: Christoph Hellwig
Date: Wed Jun 23 2021 - 04:16:42 EST


On Tue, Jun 22, 2021 at 01:15:19PM +0100, Matthew Wilcox (Oracle) wrote:
> mem_cgroup_charge() already assumed it was being passed a non-tail
> page (and looking at the callers, that's true; it's called for freshly
> allocated pages). The only real change here is that folio_nr_pages()
> doesn't compile away like thp_nr_pages() does as folio support
> is not conditional on transparent hugepage support. Reimplement
> mem_cgroup_charge() as a wrapper around folio_charge_cgroup().

Maybe rename __mem_cgroup_charge to __folio_charge_cgroup as well?