Re: [PATCH v38 1/4] scsi: ufs: Introduce HPB feature

From: Bart Van Assche
Date: Wed Jun 23 2021 - 14:13:31 EST


On 6/16/21 12:08 AM, Daejun Park wrote:
> +What: /sys/class/scsi_device/*/device/unit_descriptor/hpb_pinned_region_start_offset
> +Date: June 2021
> +Contact: Daejun Park <daejun7.park@xxxxxxxxxxx>
> +Description: This entry shows the start offset of HPB pinned region.
> +
> + The file is read only.
> +
> +What: /June/class/scsi_device/*/device/unit_descriptor/hpb_number_pinned_regions
> +Date: March 2021

Please change /June into /sys and "March 2021" into "June 2021".

> @@ -7094,6 +7119,7 @@ static int ufshcd_host_reset_and_restore(struct ufs_hba *hba)
> {
> int err;
>
> + ufshpb_reset_host(hba);
> /*
> * Stop the host controller and complete the requests
> * cleared by h/w

Shouldn't the ufshpb_reset_host() call occur under the comment instead
of above?

Thanks,

Bart.