Re: [PATCH 1/6] KVM: x86/mmu: release audited pfns

[Paolo Bonzini]

On 24/06/21 10:43, Nicholas Piggin wrote:
> Excerpts from David Stevens's message of June 24, 2021 1:57 pm:
> > From: David Stevens <stevensd@xxxxxxxxxxxx>
>
> Changelog? This looks like a bug, should it have a Fixes: tag?

Probably has been there forever... The best way to fix the bug would be 
to nuke mmu_audit.c, which I've threatened to do many times but never 
followed up on.

Paolo

> Thanks,
> Nick
>
> > Signed-off-by: David Stevens <stevensd@xxxxxxxxxxxx>
> > ---
> >   arch/x86/kvm/mmu/mmu_audit.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/x86/kvm/mmu/mmu_audit.c b/arch/x86/kvm/mmu/mmu_audit.c
> > index cedc17b2f60e..97ff184084b4 100644
> > --- a/arch/x86/kvm/mmu/mmu_audit.c
> > +++ b/arch/x86/kvm/mmu/mmu_audit.c
> > @@ -121,6 +121,8 @@ static void audit_mappings(struct kvm_vcpu *vcpu, u64 *sptep, int level)
> >   		audit_printk(vcpu->kvm, "levels %d pfn %llx hpa %llx "
> >   			     "ent %llxn", vcpu->arch.mmu->root_level, pfn,
> >   			     hpa, *sptep);
> > +
> > +	kvm_release_pfn_clean(pfn);
> >   }
> >   
> >   static void inspect_spte_has_rmap(struct kvm *kvm, u64 *sptep)
> > --
> > 2.32.0.93.g670b81a890-goog