Re: [PATCH v3 07/10] mmc: handle error from blk_ksm_register()

[Satya Tangirala]

On Wed, Jun 16, 2021 at 08:25:19PM -0700, Eric Biggers wrote:
> On Fri, Jun 04, 2021 at 07:58:57PM +0000, Satya Tangirala wrote:
> > +		/*
> > +		 * This WARN_ON should never trigger since &host->ksm won't be
> > +		 * "empty" (i.e. will support at least 1 crypto capability), an
> > +		 * MMC device's request queue doesn't support integrity, and
> > +		 * it also satisfies all the block layer constraints (i.e.
> > +		 * supports SG gaps, doesn't have chunk sectors, has a
> > +		 * sufficiently large supported max_segments per bio)
> > +		 */
> > +		WARN_ON(!blk_ksm_register(&host->ksm, q));
> > +	}
> >  }
> 
> There appear to be some MMC host drivers that set max_segments to 1, so this
> explanation may not hold.  It may hold for every driver that actually supports
> crypto, though.
Yeah, I think it does hold for every driver that actually supports
crypto. I'll check this more carefully before sending out the next
version.
> 
> - Eric