Re: [PATCH v4 01/10] scsi: ufs: Rename flags pm_op_in_progress and is_sys_suspended
From: Bart Van Assche
Date: Thu Jun 24 2021 - 13:32:42 EST
On 6/23/21 12:35 AM, Can Guo wrote:
> Rename pm_op_in_progress and is_sys_suspended to wlu_pm_op_in_progress and
> is_wlu_sys_suspended accordingly.
Can the pm_op_in_progress variable be removed if the UFS driver checks whether
q->rpm_status == RPM_SUSPENDING || q->rpm_status == RPM_RESUMING instead of
using pm_op_in_progress? The fewer state variables we maintain the lower the
chance that these are inconsistent or incorrect. See also block/blk-pm.c for
the code that sets q->rpm_status.
Thanks,
Bart.