Re: [GIT PULL] MMC fixes for v5.13-rc8

[Linus Torvalds]

On Thu, Jun 24, 2021 at 5:32 AM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
>
> Neil Armstrong (1):
>       mmc: meson-gx: use memcpy_to/fromio for dram-access-quirk

Ugh. How horribly ugly.

Why is that 'host->dram_access_quirk' test _inside_ the loop, rather
than be something like

        if (host->dram_access_quirk)
                return sg_copy_to_buffer(data->sg, data->sg_len,
                                host->bounce_buf, xfer_bytes);

at the top of the function, with meson_mmc_copy_buffer() then only
handling the mmio case?

No, I don't know this code, I'm just looking at the patch and going
"that looks really ugly".

Anyway, I've pulled it, but I thought I'd voice my reaction to it..

              Linus