Re: [PATCH v2 2/2] clk: qcom: Add MSM8976/56 Global Clock Controller (GCC) driver

[Rob Herring]

On Sat, Jun 12, 2021 at 10:43:16PM +0200, Konrad Dybcio wrote:
> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx>
> 
> Add support for the global clock controller found on MSM8956
> and MSM8976 SoCs.
> Since the multimedia clocks are actually in the GCC on these
> SoCs, this will allow drivers to probe and control basically
> all the required clocks.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx>
> Co-developed-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
> Signed-off-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
> Co-developed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>
> ---
> Changes since v1:
> - Remove the bool in probe function
> - Clean up ".name =" clk lookup
> - Add a comment under gpll0_vote clarifying that it's crucial
> - Removed CLK_GET_RATE_NOCACHE from display clocks, it still works \o/
> 
>  drivers/clk/qcom/Kconfig                     |    8 +
>  drivers/clk/qcom/Makefile                    |    1 +
>  drivers/clk/qcom/gcc-msm8976.c               | 4173 ++++++++++++++++++
>  include/dt-bindings/clock/qcom,gcc-msm8976.h |  243 +

This belongs in the binding patch and dual license it please.

>  4 files changed, 4425 insertions(+)
>  create mode 100644 drivers/clk/qcom/gcc-msm8976.c
>  create mode 100644 include/dt-bindings/clock/qcom,gcc-msm8976.h