Re: [PATCH v3] Documentation, dt, numa: Add note to empty NUMA node

[Randy Dunlap]

On 6/24/21 9:32 PM, Gavin Shan wrote:
> On 6/25/21 1:47 PM, Randy Dunlap wrote:
>> On 6/24/21 9:30 PM, Gavin Shan wrote:
>>> The empty NUMA nodes, where no memory resides in, are allowed. For
>>> these empty NUMA nodes, the 'len' of 'reg' property is zero. These
>>> empty NUMA node IDs are still valid and parsed. I finds difficulty
>>> to get where it's properly documented.
>>>
>>> So lets add note to empty NUMA nodes in the NUMA binding doc.
>>>
>>> Signed-off-by: Gavin Shan <gshan@xxxxxxxxxx>
>>> ---
>>>   Documentation/devicetree/bindings/numa.txt | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/numa.txt b/Documentation/devicetree/bindings/numa.txt
>>> index 21b35053ca5a..edf728cff155 100644
>>> --- a/Documentation/devicetree/bindings/numa.txt
>>> +++ b/Documentation/devicetree/bindings/numa.txt
>>> @@ -109,6 +109,10 @@ Example:
>>>   Dual socket system consists of 2 boards connected through ccn bus and
>>>   each board having one socket/soc of 8 cpus, memory and pci bus.
>>>   +Note that the empty NUMA nodes, which no memory resides in, are allowed.
>>
>> I would write that without "the":
>>
>> +Note that empty NUMA nodes, which no memory resides in, are allowed.
>>
>> BTW, AFAIK, NUMA nodes may contain memory, CPU(s), or I/O -- any one, two, or
>> three, without the other types of resources being present.
>>
> 
> Sure, I will drop "the" in v4.
> 
> The NUMA nodes here are memory nodes here. Since the NUMA node usually means
> memory node. I'm not sure if I change the term "NUMA node" to "NUMA memory
> node" in v4. If you agree, I would have something like this:
> 
> Note that empty memory nodes, which no memory resides in, are allowed.
> The NUMA node IDs in these empty memory nodes are still valid, but memory
> can be added into them through hotplug afterwards.

OK, that sounds fine to me.

thanks.
-- 
~Randy