Re: [PATCH 0/4] fpga/mfd/hwmon: Initial support for Silicom N5010 PAC

[Martin Hundebøll]

Hi Yilun,

On 21/06/2021 10.38, Xu Yilun wrote:
> On Mon, Jun 21, 2021 at 09:06:17AM +0200, Martin Hundebøll wrote:
> > From: Martin Hundebøll <mhu@xxxxxxxxxx>
> >
> > This is an initial set of patches for the Silciom N5010 programmable
> > accelerated card adding support for reading out sensors.
>
> Seems the card is a variant of d5005, just changes the layout of the
> sensors in BMC. It may not worth a dedicated PCI DID, and pass
> down the info all the way from
>    pcie -> dfl -> spi-altera -> m10bmc -> m10bmc-hwmon
>
> Is it possible we just have some version check in m10bmc?

I think not.

The n501x is a Silicom card, and d5005 is from Intel. The Max10 based BMC
is quite similar, which is why we use a feature revision to differentiate,
but the main FPGA register layout is a different story.

// Martin

> > I'm not really sure if these should be taken through each of the
> > affected trees separately, or just by fpga collectively?
> >
> > Based on current master.
> >
> > // Martin
> >
> > Debarati Biswas (1):
> >    fpga: dfl: Move DFH header register macros to linux/dfl.h
> >
> > Martin Hundebøll (3):
> >    fpga: dfl: pci: add device IDs for Silicom N501x PAC cards
> >    spi: spi-altera-dfl: support n5010 feature revision
> >    hwmon: intel-m10-bmc: add sensor support for Silicom N5010 card
> >
> >   drivers/fpga/dfl-pci.c              |   5 ++
> >   drivers/fpga/dfl.h                  |  48 +-----------
> >   drivers/hwmon/intel-m10-bmc-hwmon.c | 116 ++++++++++++++++++++++++++++
> >   drivers/mfd/intel-m10-bmc.c         |  12 ++-
> >   drivers/spi/spi-altera-dfl.c        |  15 +++-
> >   include/linux/dfl.h                 |  52 +++++++++++++
> >   6 files changed, 198 insertions(+), 50 deletions(-)
> >
> > --
> > 2.31.0