Re: [PATCH] HID: i2c-hid: goodix: Tie the reset line to true state of the regulator

[Doug Anderson]

Hi,

On Tue, Jun 22, 2021 at 1:49 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> 2b87ff72c696bc Douglas Anderson 2021-06-11  133         mutex_lock(&ihid_goodix->regulator_mutex);
>                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 2b87ff72c696bc Douglas Anderson 2021-06-11  134         ihid_goodix->nb.notifier_call = ihid_goodix_vdd_notify;
> 2b87ff72c696bc Douglas Anderson 2021-06-11  135         ret = regulator_register_notifier(ihid_goodix->vdd, &ihid_goodix->nb);
> 2b87ff72c696bc Douglas Anderson 2021-06-11  136         if (ret)
> 2b87ff72c696bc Douglas Anderson 2021-06-11  137                 return dev_err_probe(&client->dev, ret,
> 2b87ff72c696bc Douglas Anderson 2021-06-11  138                         "regulator notifier request failed\n");
>                                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Drop the lock before returning?

Thank you for catching that. Fixed in v2:

https://lore.kernel.org/r/20210625081818.v2.1.I358cae5e33f742765fd38485d6ddf1a4a978644d@changeid/

-Doug