Re: [PATCH v2] PCI: rockchip: Avoid accessing PCIe registers with clocks gated
From: Javier Martinez Canillas
Date: Fri Jun 25 2021 - 14:34:47 EST
On 6/25/21 4:32 PM, Bjorn Helgaas wrote:
> On Fri, Jun 25, 2021 at 09:09:36AM +0200, Javier Martinez Canillas wrote:
>> On 6/25/21 12:40 AM, Bjorn Helgaas wrote:
>
>>> I think this is also an issue with the following other drivers. They all
>>> set the handler to something that uses an IRQ domain before they
>>> actually initialize the domain:
>>
>> Yes, I agreed with your assessment and also noticed that others drivers have
>> similar issues. I just don't have any of those platforms to try to reproduce
>> the bugs and test a fix.
>
> Even if you don't have other platforms for testing, I'm thrilled when
> folks point out issues with them and (given time and inclination) post
> patches for them.
>
> I'd much rather fix *all* instances of the problem than just one, even
> if we can't test them all. Frequently driver maintainers will review
> and test patches for their hardware even if we can't.
>
Ok. I'll try to make some time next week to look at these drivers then
and post at least RFC/RFT patches for people with available hardware to
test the changes.
Best regards,
--
Javier Martinez Canillas
Software Engineer
New Platform Technologies Enablement team
RHEL Engineering