Re: [PATCH] sched: cgroup SCHED_IDLE support

[Josh Don]

On Fri, Jun 25, 2021 at 1:21 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> On Tue, Jun 08, 2021 at 04:11:32PM -0700, Josh Don wrote:
> > +static int se_is_idle(struct sched_entity *se)
> > +{
> > +     if (entity_is_task(se))
> > +             return task_has_idle_policy(task_of(se));
> > +     return cfs_rq_is_idle(group_cfs_rq(se));
> > +}
>
> I'm conflicted on this, on the one hand, since we want 'idle' to be a
> sched_entity propery, I'd say, make it a sched_entity field, OTOH,
> that's probably going to be a mess too :/
>
> Let me read more..

Yea, I see both arguments; a field probably wouldn't be that bad. In
any case, this seemed reasonable and avoids more touchpoints in
core.c, so *shrug*.