RE: [PATCH v7 3/4] dt-bindings: firmware: Add bindings for xilinx firmware

[Nava kishore Manne]

Hi Rob,

	Please find my response inline.

> -----Original Message-----
> From: Rob Herring <robh@xxxxxxxxxx>
> Sent: Thursday, June 10, 2021 9:34 PM
> To: Nava kishore Manne <navam@xxxxxxxxxx>
> Cc: Michal Simek <michals@xxxxxxxxxx>; mdf@xxxxxxxxxx; trix@xxxxxxxxxx;
> arnd@xxxxxxxx; Rajan Vaja <RAJANV@xxxxxxxxxx>;
> gregkh@xxxxxxxxxxxxxxxxxxx; Amit Sunil Dhamne
> <amitsuni@xxxxxxxxxxxxxxx>; Tejas Patel <tejasp@xxxxxxxxxxxxxxx>;
> zou_wei@xxxxxxxxxx; Sai Krishna Potthuri <lakshmis@xxxxxxxxxx>; Ravi
> Patel <RAVIPATE@xxxxxxxxxx>; iwamatsu@xxxxxxxxxxx; Jiaying Liang
> <jliang@xxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> fpga@xxxxxxxxxxxxxxx; git <git@xxxxxxxxxx>; chinnikishore369@xxxxxxxxx
> Subject: Re: [PATCH v7 3/4] dt-bindings: firmware: Add bindings for xilinx
> firmware
> 
> On Fri, Jun 04, 2021 at 05:03:31PM +0530, Nava kishore Manne wrote:
> > Add documentation to describe Xilinx firmware driver bindings.
> > Firmware driver provides an interface to firmware APIs.
> > Interface APIs can be used by any driver to communicate to Platform
> > Management Unit.
> >
> > Signed-off-by: Nava kishore Manne <nava.manne@xxxxxxxxxx>
> > ---
> > Changes for v4:
> >               -Added new yaml file for xilinx firmware
> >                as suggested by Rob.
> >
> > Changes for v5:
> >               -Fixed some minor issues and updated the fpga node name to
> versal_fpga.
> >
> > Changes for v6:
> >               -Added AES and Clk nodes as a sub nodes to the firmware node.
> >
> > Changes for v7:
> >               -Fixed child nodes format ssues.
> >
> >  .../firmware/xilinx/xlnx,zynqmp-firmware.yaml | 94
> > +++++++++++++++++++
> >  1 file changed, 94 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
> firmware
> > .yaml
> 
> You need to remove xlnx,zynqmp-firmware.txt
> 

Will fix in v8.

> >
> > diff --git
> > a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
> firmwa
> > re.yaml
> > b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
> firmwa
> > re.yaml
> > new file mode 100644
> > index 000000000000..8e0241c4c137
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-fi
> > +++ rmware.yaml
> > @@ -0,0 +1,94 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> > +http://devicetree.org/schemas/firmware/xilinx/xlnx,zynqmp-firmware.ya
> > +ml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Xilinx firmware driver
> > +
> > +maintainers:
> > +  - Nava kishore Manne <nava.manne@xxxxxxxxxx>
> > +
> > +description:
> > +  The zynqmp-firmware node describes the interface to platform
> firmware.
> > +  ZynqMP has an interface to communicate with secure firmware.
> > +Firmware
> > +  driver provides an interface to firmware APIs. Interface APIs can
> > +be
> > +  used by any driver to communicate to PMUFW(Platform Management
> Unit).
> > +  These requests include clock management, pin control, device
> > +control,
> > +  power management service, FPGA service and other platform
> > +management
> > +  services.
> > +
> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - description:
> > +          For implementations complying for Zynq Ultrascale+ MPSoC.
> > +        const: xlnx,zynqmp-firmware
> > +
> > +      - description:
> > +          For implementations complying for Versal.
> > +        const: xlnx,versal-firmware
> > +
> > +  method:
> > +    description: |
> > +                 The method of calling the PM-API firmware layer.
> > +                 Permitted values are.
> > +                 - "smc" : SMC #0, following the SMCCC
> > +                 - "hvc" : HVC #0, following the SMCCC
> > +
> > +    $ref: /schemas/types.yaml#/definitions/string-array
> > +    enum:
> > +      - smc
> > +      - hvc
> > +
> > +  "versal_fpga":
> 
> Don't need quotes
> 

Will fix in v8.

> > +    $ref: /schemas/fpga/xlnx,versal-fpga.yaml#
> > +    description: Compatible of the FPGA device.
> > +    type: object
> > +
> > +  "zynqmp-aes":
> 
> Don't need quotes
> 

Will fix in v8.

> > +    $ref: /schemas/crypto/xlnx,zynqmp-aes.yaml#
> > +    description: |
> > +                 The ZynqMP AES-GCM hardened cryptographic accelerator is
> > +                 used to encrypt or decrypt the data with provided key and
> > +                 initialization vector.
> 
> Don't need '|' here (there's no formatting) and indent 2 more than
> 'description'.
> 

Will fix in v8.

Regards,
Navakishore.