Re: [PATCH 1/1] clk: tegra: tegra124-emc: Fix possible memory leak

From: Stephen Boyd
Date: Sun Jun 27 2021 - 19:44:10 EST


Quoting Leizhen (ThunderTown) (2021-06-25 18:32:46)
>
>
> On 2021/6/26 7:31, Stephen Boyd wrote:
> > Quoting Zhen Lei (2021-06-17 01:27:59)
> >> When krealloc() fails to expand the memory and returns NULL, the original
> >> memory is not released. In this case, the original "timings" scale should
> >> be maintained.
> >>
> >> Fixes: 888ca40e2843 ("clk: tegra: emc: Support multiple RAM codes")
> >> Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
> >> ---
> >
> > Looks correct, but when does krealloc() return NULL? My read of the
> > kerneldoc is that it would return the original memory if the new
> > allocation "failed".
>
> That must be the wrong description in the document. For example, the original

Can you fix the kernel doc then?