Re: [PATCH v4 01/10] scsi: ufs: Rename flags pm_op_in_progress and is_sys_suspended

[Can Guo]

On 2021-06-28 15:01, Can Guo wrote:
> On 2021-06-25 07:42, Bart Van Assche wrote:
> > On 6/23/21 12:35 AM, Can Guo wrote:
> > > Rename pm_op_in_progress and is_sys_suspended to 
> > > wlu_pm_op_in_progress and
> > > is_wlu_sys_suspended accordingly.
> >
> > Can the is_wlu_sys_suspended member variable be removed by checking
> > dev->power.is_suspended where dev represents the WLUN?
>
> No, PM set dev->power.is_suspended to "false" even the device failed 
> resuming,
> while is_wlu_sys_suspended can be used to tell that.

FYI,

892 /**
893  * device_resume - Execute "resume" callbacks for given device.
894  * @dev: Device to handle.
895  * @state: PM transition of the system being carried out.
896  * @async: If true, the device is being resumed asynchronously.
897  */
898 static int device_resume(struct device *dev, pm_message_t state, 
bool async)
...
967  End:
968 	error = dpm_run_callback(callback, dev, state, info);
969 	dev->power.is_suspended = false;
...

Can Guo.

> Thanks,
>
> Can Guo.
>
> > Thanks,
> >
> > Bart.