Aw: Re: [PATCH v4] thermal: mediatek: add sensors-support
From: Frank Wunderlich
Date: Mon Jun 28 2021 - 06:06:24 EST
Hi,
A gentle ping as it is reviewed but not yet visible in thermal tree [1] i guess it should do,right?
regards Frank
[1] https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/log/?h=thermal/next
> Gesendet: Mittwoch, 09. Juni 2021 um 10:09 Uhr
> Von: "Matthias Brugger" <matthias.bgg@xxxxxxxxx>
> An: "Frank Wunderlich" <linux@xxxxxxxxx>, linux-mediatek@xxxxxxxxxxxxxxxxxxx
> Cc: "Frank Wunderlich" <frank-w@xxxxxxxxxxxxxxx>, "Daniel Lezcano" <daniel.lezcano@xxxxxxxxxx>, "Amit Kucheria" <amitk@xxxxxxxxxx>, linux-pm@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
> Betreff: Re: [PATCH v4] thermal: mediatek: add sensors-support
>
>
>
> On 08/06/2021 17:45, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> >
> > add HWMON-support to mediateks thermal driver to allow lm-sensors
> > userspace tools read soc temperature
> >
> > Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
>
> Reviewed-by: Matthias Brugger <matthias.bgg@xxxxxxxxx>
>
> > ---
> > v4: change message to dev_warn as suggested by matthias
> > v3: drop no_hwmon
> > v2: drop ifdef and used devm_thermal_add_hwmon_sysfs
> > ---
> > drivers/thermal/mtk_thermal.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> > index 97e8678ccf0e..ede94eadddda 100644
> > --- a/drivers/thermal/mtk_thermal.c
> > +++ b/drivers/thermal/mtk_thermal.c
> > @@ -23,6 +23,8 @@
> > #include <linux/reset.h>
> > #include <linux/types.h>
> >
> > +#include "thermal_hwmon.h"
> > +
> > /* AUXADC Registers */
> > #define AUXADC_CON1_SET_V 0x008
> > #define AUXADC_CON1_CLR_V 0x00c
> > @@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev)
> > goto err_disable_clk_peri_therm;
> > }
> >
> > + ret = devm_thermal_add_hwmon_sysfs(tzdev);
> > + if (ret)
> > + dev_warn(&pdev->dev, "error in thermal_add_hwmon_sysfs");
> > +
> > return 0;
> >
> > err_disable_clk_peri_therm:
> >
>