Re: [PATCH] perf vendor events power10: Adds 24x7 nest metric events for power10 platform

[Paul A. Clarke]

On Mon, Jun 28, 2021 at 11:58:54AM +0530, kajoljain wrote:
> 
> 
> On 6/25/21 6:51 PM, Paul A. Clarke wrote:
> > On Fri, Jun 25, 2021 at 05:29:48PM +0530, Kajol Jain wrote:
> >> Patch adds 24x7 nest metric events for POWER10.
> >>
> >> Signed-off-by: Kajol Jain <kjain@xxxxxxxxxxxxx>
> >> ---
> >>  .../arch/powerpc/power10/nest_metrics.json    | 491 ++++++++++++++++++
> >>  1 file changed, 491 insertions(+)
> >>  create mode 100644 tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json
> >>
> >> diff --git a/tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json b/tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json
> >> new file mode 100644
> >> index 000000000000..b79046cd8b09
> >> --- /dev/null
> >> +++ b/tools/perf/pmu-events/arch/powerpc/power10/nest_metrics.json
> >> @@ -0,0 +1,491 @@
> >> +[
> >> +    {
> >> +      "MetricName": "VEC_GROUP_PUMP_RETRY_RATIO_P01",
> >> +      "BriefDescription": "VEC_GROUP_PUMP_RETRY_RATIO_P01",
> > 
> > Is it possible to get better descriptions than just a restatement of the
> > name, or no description at all?
> > 
> > This comment obviously applies to almost all of the metrics herein.
> 
> Hi Paul,
>    Thanks for reviewing the patch. Sure I will remove description part for now.

My sentence didn't parse well, sorry...

What I really meant was more like "Is it possible to get better descriptions?
Having just a restatement of the name (or no description at all in some cases)
is not helpful."

So, can we provide better descriptions of the metrics?

PC