Re: [PATCH 2/3] dt-bindings: soc: qcom: aoss: Convert to YAML

[Bjorn Andersson]

On Mon 28 Jun 09:49 CDT 2021, Manivannan Sadhasivam wrote:

> On Fri, Jun 25, 2021 at 04:40:17PM -0700, Bjorn Andersson wrote:
> > Convert to YAML in order to allow validation.
> > 
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > ---
> > 
> > I'm aware that this conflicts with Sibi's removal of '#power-domain-cells', but
> > that's a trivial change regardless of which of the two patches gets in first.
> > 
> >  .../bindings/soc/qcom/qcom,aoss-qmp.txt       |  90 --------------
> >  .../bindings/soc/qcom/qcom,aoss-qmp.yaml      | 115 ++++++++++++++++++
> >  2 files changed, 115 insertions(+), 90 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
> >  create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml
> > 
> 
> [...]
> 
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - mboxes
> > +  - "#clock-cells"
> 
> The old binding lists this property as optional but you're marking it
> as required. And by looking at the driver it seems to be optional only.
> 

You're right, missed that detail. Will respin accordingly.

> > +  - "#power-domain-cells"
> 
> This one was marked optional as well but the driver registers the pd's
> unconditionally, so I guess it is fine.
> 

I think this should be a required property, but the conversion should
convert the binding, so I'll update accordingly.

Also, Sibi has a series that drops the power-domains, due to some
unforeseen complications related to suspend, so there's no need to
follow up with a change to the binding in this regard.

Thanks,
Bjorn

> Thanks,
> Mani
> 
> > +
> > +additionalProperties: false
> > +
> > +patternProperties:
> > +  "^(cx|mx|ebi)$":
> > +    type: object
> > +    description:
> > +      The AOSS side channel also provides the controls for three cooling devices,
> > +      these are expressed as subnodes of the QMP node. The name of the node is
> > +      used to identify the resource and must therefor be "cx", "mx" or "ebi".
> > +
> > +    properties:
> > +      "#cooling-cells":
> > +        const: 2
> > +
> > +    required:
> > +      - "#cooling-cells"
> > +
> > +    additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +    aoss_qmp: qmp@c300000 {
> > +      compatible = "qcom,sdm845-aoss-qmp", "qcom,aoss-qmp";
> > +      reg = <0x0c300000 0x100000>;
> > +      interrupts = <GIC_SPI 389 IRQ_TYPE_EDGE_RISING>;
> > +      mboxes = <&apss_shared 0>;
> > +
> > +      #clock-cells = <0>;
> > +      #power-domain-cells = <1>;
> > +
> > +      cx_cdev: cx {
> > +        #cooling-cells = <2>;
> > +      };
> > +
> > +      mx_cdev: mx {
> > +        #cooling-cells = <2>;
> > +      };
> > +    };
> > +...
> > -- 
> > 2.29.2
> >