Re: [PATCH v2] scsi: ufs: Refactor ufshcd_is_intr_aggr_allowed()

[Bart Van Assche]

On 6/27/21 10:58 PM, Keoseong Park wrote:
> Simplify if else statement to return statement,
> and remove code related to CONFIG_SCSI_UFS_DWC that is not in use.
> 
> v1 -> v2
> Remove code related to CONFIG_SCSI_UFS_DWC that is not in use.
> 
> Cc: Joao Pinto <jpinto@xxxxxxxxxxxx>
> Signed-off-by: Keoseong Park <keosung.park@xxxxxxxxxxx>
> ---
>  drivers/scsi/ufs/ufshcd.h | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index c98d540ac044..c9faca237290 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -893,16 +893,8 @@ static inline bool ufshcd_is_rpm_autosuspend_allowed(struct ufs_hba *hba)
>  
>  static inline bool ufshcd_is_intr_aggr_allowed(struct ufs_hba *hba)
>  {
> -/* DWC UFS Core has the Interrupt aggregation feature but is not detectable*/
> -#ifndef CONFIG_SCSI_UFS_DWC
> -	if ((hba->caps & UFSHCD_CAP_INTR_AGGR) &&
> -	    !(hba->quirks & UFSHCD_QUIRK_BROKEN_INTR_AGGR))
> -		return true;
> -	else
> -		return false;
> -#else
> -return true;
> -#endif
> +	return (hba->caps & UFSHCD_CAP_INTR_AGGR) &&
> +		!(hba->quirks & UFSHCD_QUIRK_BROKEN_INTR_AGGR);
>  }

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>