Re: [GIT PULL] TPM DEVICE DRIVER changes for v5.14

From: Stefan Berger
Date: Mon Jun 28 2021 - 15:35:39 EST



On 6/28/21 3:27 PM, Linus Torvalds wrote:
On Mon, Jun 28, 2021 at 12:21 PM Stefan Berger <stefanb@xxxxxxxxxxxxx> wrote:
Correct, and the code (certs/Makefile) is surrounded by the check for
this particular file here, so it won't touch anything else:
Ahh, I missed that part.

Can we just make it really really obvious, and not use
CONFIG_MODULE_SIG_KEY at all, then?

IOW, make these literally be about "certs/signing_key.pem" and nothing
else, so that when people grep for this, or look at the Makefile, they
don't fall into that trap I fell into?

Yes, sir.

   Stefan



That also would make it obvious that there are no pathname quoting issues etc.

Linus