Re: [PATCH] kbuild: allow checking single device tree file

[Dmitry Baryshkov]

Hi Rob,

On Wed, 19 May 2021 at 16:43, Rob Herring <robh@xxxxxxxxxx> wrote:
>
> On Thu, May 13, 2021 at 10:18 AM Dmitry Baryshkov
> <dmitry.baryshkov@xxxxxxxxxx> wrote:
> >
> > Add support for testing single device tree file by running
> > 'make tree.dt.yaml', e.g. 'make ARCH=arm64 qcom/qrb5165-rb5.dt.yaml'.
> > This looks useful for checking idividual changes to dts files.
>
> typo
>
> I'd rather not expose .*.dt.yaml as I want to make checking not
> optional and I have some plans of integrating the schema checks into
> dtc which would eliminate .dt.yaml files. Instead, I think %.dtb
> targets should run the checks always.
>
> >
> > Cc: Rob Herring <robh@xxxxxxxxxx>
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > ---
> >  Makefile | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/Makefile b/Makefile
> > index 53d09c414635..b36a3d48eb68 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1383,6 +1383,10 @@ ifneq ($(dtstree),)
> >  %.dtbo: include/config/kernel.release scripts_dtc
> >         $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@
> >
> > +%.dt.yaml: include/config/kernel.release scripts_dtc
> > +       $(Q)$(MAKE) $(build)=Documentation/devicetree/bindings Documentation/devicetree/bindings/processed-schema.json
>
> I don't think we should expose this detail (processed-schema.json) to
> the top-level makefile. This will be built if 'dt_binding_check' is a
> dependency with CHECK_DTBS=y set.
>
> > +       $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@ CHECK_DTBS=y
>
> CHECK_DTBS here doesn't work. It has to be exported.
>
> So here's my modified patch (%.dtbo should probably be included too,
> but I'm not yet sure how well the schema checks will work on them):

Please excuse me for letting this float for some time. Do you plan to
submit your patch?
Would you like me to do it instead?

> 8<---------------------------------------------------------
> diff --git a/Makefile b/Makefile
> index 53d09c414635..a1e246956d65 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1377,12 +1377,18 @@ endif
>
>  ifneq ($(dtstree),)
>
> -%.dtb: include/config/kernel.release scripts_dtc
> +%.dtb: %.dt.yaml
>         $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@
>
>  %.dtbo: include/config/kernel.release scripts_dtc
>         $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@
>
> +ifneq ($(filter %.dtb, $(MAKECMDGOALS)),)
> +export CHECK_DTBS=y
> +endif
> +%.dt.yaml: dt_binding_check include/config/kernel.release scripts_dtc
> +       $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@
> +



-- 
With best wishes
Dmitry