Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver
From: Jie Deng
Date: Mon Jun 28 2021 - 23:04:22 EST
On 2021/6/28 22:58, Wolfram Sang wrote:
If adding support incrementally works for such an interface, this makes
sense as well.
So, where are we? As I understand, this v10 does not support I2C
transactions (or I2C_RDWR as you said). But you want to support all
clients. So, this doesn't match, or?
I hope we can have a minimum working driver get merged first so that we
can have a base.
The v10 has three remaining problems:
1. To remove vi->adap.class = I2C_CLASS_DEPRECATED; (already
confirmed by Wolfram)
2. Use #ifdef CONFIG_PM_SLEEP to replace the "__maybe_unused"
(already confirmed by Arnd)
3. It seems the I2C core takes care of locking already, so is it
safy to remove "struct mutex lock in struct virtio_i2c"?
(Raised by Viresh, still need Wolfram's confirmation)
Regards,
Jie