Re: [PATCH net] net: bcmgenet: ensure EXT_ENERGY_DET_MASK is clear

[Florian Fainelli]

On 6/25/2021 3:03 PM, Florian Fainelli wrote:
> On 6/25/21 2:57 PM, Doug Berger wrote:
> > Setting the EXT_ENERGY_DET_MASK bit allows the port energy detection
> > logic of the internal PHY to prevent the system from sleeping. Some
> > internal PHYs will report that energy is detected when the network
> > interface is closed which can prevent the system from going to sleep
> > if WoL is enabled when the interface is brought down.
> >
> > Since the driver does not support waking the system on this logic,
> > this commit clears the bit whenever the internal PHY is powered up
> > and the other logic for manipulating the bit is removed since it
> > serves no useful function.
> >
> > Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")
> > Signed-off-by: Doug Berger <opendmb@xxxxxxxxx>
>
> Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>

Doug, it looks like this patch introduces an unused "reg" variable 
warning at lines 3296 and 4137 which is why the patch was marked as 
"Changes Requested":

https://patchwork.kernel.org/project/netdevbpf/patch/20210625215732.209588-1-opendmb@xxxxxxxxx/
https://patchwork.hopto.org/static/nipa//507371/12345957/build_32bit


--
Florian