Re: [PATCH net-next v3 1/2] once: implement DO_ONCE_LITE for non-fast-path "do once" functionality

From: Petr Mladek
Date: Tue Jun 29 2021 - 03:33:49 EST


On Mon 2021-06-28 11:14:46, Steven Rostedt wrote:
> On Mon, 28 Jun 2021 09:50:06 -0400
> Tanner Love <tannerlove.kernel@xxxxxxxxx> wrote:
>
> > Certain uses of "do once" functionality reside outside of fast path,
> > and so do not require jump label patching via static keys, making
> > existing DO_ONCE undesirable in such cases.
> >
> > Replace uses of __section(".data.once") with DO_ONCE_LITE(_IF)?
>
> I hate the name "_LITE" but can't come up with something better.
>
> Maybe: DO_ONCE_SLOW() ??

Or rename the original DO_ONCE() to DO_ONCE_FAST() because it is
more tricky to be fast. And call the "normal" implementation DO_ONCE().

> Anyway, besides my bike-shedding comment above...

Same here :-)

Acked-by: Petr Mladek <pmladek@xxxxxxxx>

Best Regards,
Petr