Re: [PATCH v2 3/5] spi: spi-altera-dfl: support n5010 feature revision

[Martin Hundebøll]

On 28/06/2021 19.39, Moritz Fischer wrote:
> On Fri, Jun 25, 2021 at 09:42:11AM +0200, Martin Hundebøll wrote:
> > From: Martin Hundebøll<mhu@xxxxxxxxxx>
> >
> > The Max10 BMC on the Silicom n5010 PAC is slightly different than the
> > existing BMC's, so use a dedicated feature revision detect it.
> >
> > Signed-off-by: Martin Hundebøll<mhu@xxxxxxxxxx>
> > ---
> >
> > Changes since v1:
> >   * use feature revision from struct dfl_device instead of reading it
> >     from io-mem
> >
> >   drivers/spi/spi-altera-dfl.c | 15 +++++++++++++--
> >   1 file changed, 13 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/spi/spi-altera-dfl.c b/drivers/spi/spi-altera-dfl.c
> > index 3e32e4fe5895..f6cf7c8d9dac 100644
> > --- a/drivers/spi/spi-altera-dfl.c
> > +++ b/drivers/spi/spi-altera-dfl.c
> > @@ -111,6 +111,13 @@ static struct spi_board_info m10_bmc_info = {
> >   	.chip_select = 0,
> >   };
> >   
> > +static struct spi_board_info m10_n5010_bmc_info = {
> > +	.modalias = "m10-n5010",
> > +	.max_speed_hz = 12500000,
> > +	.bus_num = 0,
> > +	.chip_select = 0,
> > +};
> Is there no way to query the mc for version info?

Do you mean reading the BMC variant (i.e. n5010 / d5005 / n3000) from a
register?

Not in a uniform way across the different boards that I'm aware of. But
isn't this what the DFL feature revision is meant for?

// Martin