Re: [PATCH] fs: ntfs: super: added return error value while map failed

From: Qu Wenruo
Date: Tue Jun 29 2021 - 08:31:18 EST


Wrong subject, it's not ntfs.

On 2021/6/29 下午5:53, lijian_8010a29@xxxxxxx wrote:
From: lijian <lijian@xxxxxxxxxx>

Still, you guys should try to send from your yulong.com mail box, not 163.


When lookup_extent_mapping failed, should return '-ENOENT'.

Signed-off-by: lijian <lijian@xxxxxxxxxx>

Some maintainer is OK with name like all lower letters, but at least to
my eyes, Li Jian <lijian@xxxxxxxxxx> is much easier to read.

Thanks,
Qu

---
fs/btrfs/extent_map.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/extent_map.c
index 4a8e02f7b6c7..e9d9f2bfc11d 100644
--- a/fs/btrfs/extent_map.c
+++ b/fs/btrfs/extent_map.c
@@ -305,8 +305,10 @@ int unpin_extent_cache(struct extent_map_tree *tree, u64 start, u64 len,

WARN_ON(!em || em->start != start);

- if (!em)
+ if (!em) {
+ ret = -ENOENT;
goto out;
+ }

em->generation = gen;
clear_bit(EXTENT_FLAG_PINNED, &em->flags);