Re: [PATCH v5] rtc: pcf2127: handle timestamp interrupts

From: Mian Yousaf Kaukab
Date: Tue Jun 29 2021 - 10:52:32 EST


On Mon, Jun 28, 2021 at 11:42:03AM +0200, Bruno Thomsen wrote:
> Hi again,
>
> Forgot another important comment. After you moved code to
> pcf2127_rtc_ts_read() it seems to lookup pcf2127 struct wrong.
>
> struct pcf2127 *pcf2127 = dev_get_drvdata(dev->parent);
Good catch! I will fix it by calling pcf2127_rtc_ts_read(dev->parent).
dev_get_drvdata(dev) is correct from the irq path.
>
> /Bruno
>
BR,
Yousaf