Re: [RESEND PATCH v2 1/2] spi:amd: Add support for latest platform

[kernel test robot]

Hi Nehal,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on spi/for-next]
[also build test ERROR on v5.13 next-20210629]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Nehal-Bakulchandra-Shah/spi-amd-Support-for-new-generation-of-AMD-SOCs/20210630-004001
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: arm-randconfig-r025-20210628 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project aad87328fabff9382bac0b452c83934515e6d0c8)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/dafe3f01e7cd854b133ee3feb6306e883d38fc15
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Nehal-Bakulchandra-Shah/spi-amd-Support-for-new-generation-of-AMD-SOCs/20210630-004001
        git checkout dafe3f01e7cd854b133ee3feb6306e883d38fc15
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=arm SHELL=/bin/bash drivers/spi/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/spi/spi-amd.c:141:28: error: incomplete definition of type 'struct amd_spi_devtype_data'
           if (!amd_spi->devtype_data->version)
                ~~~~~~~~~~~~~~~~~~~~~^
   drivers/spi/spi-amd.c:61:15: note: forward declaration of 'struct amd_spi_devtype_data'
           const struct amd_spi_devtype_data *devtype_data;
                        ^
   drivers/spi/spi-amd.c:164:40: error: incomplete definition of type 'struct amd_spi_devtype_data'
           u32 status_reg = amd_spi->devtype_data->spi_status;
                            ~~~~~~~~~~~~~~~~~~~~~^
   drivers/spi/spi-amd.c:61:15: note: forward declaration of 'struct amd_spi_devtype_data'
           const struct amd_spi_devtype_data *devtype_data;
                        ^
   drivers/spi/spi-amd.c:191:28: error: incomplete definition of type 'struct amd_spi_devtype_data'
           if (!amd_spi->devtype_data->version)
                ~~~~~~~~~~~~~~~~~~~~~^
   drivers/spi/spi-amd.c:61:15: note: forward declaration of 'struct amd_spi_devtype_data'
           const struct amd_spi_devtype_data *devtype_data;
                        ^
   drivers/spi/spi-amd.c:289:27: error: incomplete definition of type 'struct amd_spi_devtype_data'
           if (amd_spi->devtype_data->version)
               ~~~~~~~~~~~~~~~~~~~~~^
   drivers/spi/spi-amd.c:61:15: note: forward declaration of 'struct amd_spi_devtype_data'
           const struct amd_spi_devtype_data *devtype_data;
                        ^
   4 errors generated.


vim +141 drivers/spi/spi-amd.c

   136	
   137	static void amd_spi_set_opcode(struct spi_master *master, u8 cmd_opcode)
   138	{
   139		struct amd_spi *amd_spi = spi_master_get_devdata(master);
   140	
 > 141		if (!amd_spi->devtype_data->version)
   142			amd_spi_setclear_reg32(master, AMD_SPI_CTRL0_REG, cmd_opcode,
   143					       AMD_SPI_OPCODE_MASK);
   144		else
   145			amd_spi_writereg8(master, AMD_SPI_OPCODE_REG, cmd_opcode);
   146	}
   147	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip