Re: [PATCH v0 2/2] arm64: dts: rockchip: add support for Firefly ROC-RK3399-PC-PLUS

[Levin]

Hi Heiko,


Thanks for your reply.


On 2021-06-29 5:32 PM, Heiko Stübner wrote:
> Am Dienstag, 29. Juni 2021, 11:30:10 CEST schrieb Heiko Stübner:
> > Hi Levin,
> >
> > Am Dienstag, 29. Juni 2021, 11:15:59 CEST schrieb Levin:
> > > Hi all, is it possible to turn on some codec mixer switch in the device
> > > tree?
> > I don't think that is appropriate and/or/ possible in the devicetree.
> >
> > Instead I think you want an Alsa UCM profile for it, see:
> > https://github.com/alsa-project/alsa-ucm-conf/tree/master/ucm2/Rockchip

Alsa UCM profile is a complete solution, yet it requires more labor work 
of adding a complex profile with all the controls.


The problem is, music/video player knows nothing of the mixers. And with 
currently codec driver setting, user cannot

hear any sound until he turns on two mixer switch.


I hope to have a "simple-audio-card,switch" property here.


> > > Currently, to hear to sound, we need to run the following commands from
> > > the user space:
> > >
> > >     # turn on mixer switch
> > >
> > >     amixer -c 1 sset 'Left Mixer' on
> > >     amixer -c 1 sset 'Right Mixer' on
> > >
> > >     # raise volume
> > >
> > >     amixer -c 1 sset 'Output 2' 36
> > >
> > >
> > > If these settings can be embedded into device tree, and set by kernel as
> > > initial ALSA path settings,
> > >
> > > user can hear the sound with zero ALSA config. That'll be great.
> > >
> > >
> > > On 2021-06-28 11:54 AM, djw@xxxxxxxxxxxxx wrote:
> > > > +
> > > > +	es8388-sound {
> > > > +		compatible = "simple-audio-card";
> > > > +		pinctrl-names = "default";
> > > > +		pinctrl-0 = <&hp_det_pin>;
> > > > +		simple-audio-card,name = "rockchip,es8388-codec";
> and I guess you'd want a more specific name as that config likely is board-specific
> not for all boards using the es8388-codec?
>
>
> Heiko

I got what you mean now. It should be renamed to a board-specific card 
name if using Alsa UCM profile, right ?

--

Best Regards!

Levin Du