Re: [PATCH v7 00/20] Introduce threaded trace streaming for basic perf record operation

[Bayduraev, Alexey V]

Hi,

On 30.06.2021 9:09, Namhyung Kim wrote:
> On Mon, Jun 28, 2021 at 1:11 AM Bayduraev, Alexey V
> <alexey.v.bayduraev@xxxxxxxxxxxxxxx> wrote:
>>
>> Hello,
>>
>> On 27.06.2021 3:46, Namhyung Kim wrote:
>>> Hello,
>>>
>>> On Tue, Jun 22, 2021 at 1:42 AM Alexey Bayduraev
>>> <alexey.v.bayduraev@xxxxxxxxxxxxxxx> wrote:
>>>>
>>>> Changes in v7:
>>>> - fixed possible crash after out_free_threads label
>>>> - added missing pthread_attr_destroy() call
>>>> - added check of correctness of user masks
>>>> - fixed zsts_data finalization
>>>>
>> [SNIP]
>>> Thanks for your work, mostly looks good now.
>>>
>>> I have a question, where are the synthesized records saved?
>>> Is it the data.0 file?
>>
>> Thanks for the review.
>>
>> As I understand the synthesized records (as well as other user-space
>> records) are saved to perf.data/data, kernel records are saved to
>> perf.data/data.<CPU>
> 
> Ah, ok.  I saw you added a reader for the file in patch 20/20.
> Maybe we can save all tracking records (task/mmap) there
> in the future.
> 
> For the patchset,
>   Acked-by: Namhyung Kim <namhyung@xxxxxxxxx>

Thank you so much for your time spent on this review. 

Can I resend the patchset with additional patch that address your nitpicks?
To not re-review the entire patchset.

Regards,
Alexey
> 
> Thanks,
> Namhyung
>