Re: [PATCH 1/3 v2] sh: fix kconfig unmet dependency warning for FRAME_POINTER

From: John Paul Adrian Glaubitz
Date: Wed Jun 30 2021 - 05:32:46 EST


On 6/28/21 12:05 AM, Randy Dunlap wrote:
> FRAME_POINTER depends on DEBUG_KERNEL so DWARF_UNWINDER should
> depend on DEBUG_KERNEL before selecting FRAME_POINTER.
>
> WARNING: unmet direct dependencies detected for FRAME_POINTER
> Depends on [n]: DEBUG_KERNEL [=n] && (M68K || UML || SUPERH [=y]) || ARCH_WANT_FRAME_POINTERS [=n]
> Selected by [y]:
> - DWARF_UNWINDER [=y]
>
> Fixes: bd353861c735 ("sh: dwarf unwinder support.")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Matt Fleming <matt@xxxxxxxxxxxxxxxxx>
> Cc: Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx>
> Cc: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>
> Cc: Rich Felker <dalias@xxxxxxxx>
> Cc: linux-sh@xxxxxxxxxxxxxxx
> Cc: John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>
> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> v2: drop Paul Mundt from Cc: list;
> add this previously sent patch to the series;
> add more Cc's;
>
> arch/sh/Kconfig.debug | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20210625.orig/arch/sh/Kconfig.debug
> +++ linux-next-20210625/arch/sh/Kconfig.debug
> @@ -57,6 +57,7 @@ config DUMP_CODE
>
> config DWARF_UNWINDER
> bool "Enable the DWARF unwinder for stacktraces"
> + depends on DEBUG_KERNEL
> select FRAME_POINTER
> default n
> help
>

Boot-tested on my SH-7785LCR without any issues (as expected).

Tested-by: John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@xxxxxxxxxx
`. `' Freie Universitaet Berlin - glaubitz@xxxxxxxxxxxxxxxxxxx
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913