RE: [PATCH net] net: stmmac: Terminate FPE workqueue in suspend

From: Ismail, Mohammad Athari
Date: Wed Jun 30 2021 - 05:36:27 EST




> -----Original Message-----
> From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Wednesday, June 30, 2021 5:32 PM
> To: Ismail, Mohammad Athari <mohammad.athari.ismail@xxxxxxxxx>
> Cc: Alexandre Torgue <alexandre.torgue@xxxxxx>; Jose Abreu
> <joabreu@xxxxxxxxxxxx>; David S . Miller <davem@xxxxxxxxxxxxx>; Jakub
> Kicinski <kuba@xxxxxxxxxx>; Giuseppe Cavallaro <peppe.cavallaro@xxxxxx>;
> Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>; Ong, Boon Leong
> <boon.leong.ong@xxxxxxxxx>; Voon, Weifeng <weifeng.voon@xxxxxxxxx>; Tan,
> Tee Min <tee.min.tan@xxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH net] net: stmmac: Terminate FPE workqueue in suspend
>
> On Wed, Jun 30, 2021 at 05:17:54PM +0800,
> mohammad.athari.ismail@xxxxxxxxx wrote:
> > From: Mohammad Athari Bin Ismail <mohammad.athari.ismail@xxxxxxxxx>
> >
> > Add stmmac_fpe_stop_wq() in stmmac_suspend() to terminate FPE
> > workqueue during suspend. So, in suspend mode, there will be no FPE
> > workqueue available. Without this fix, new additional FPE workqueue
> > will be created in every suspend->resume cycle.
> >
> > Fixes: 5a5586112b92 ("net: stmmac: support FPE link partner
> > hand-shaking procedure")
> > Signed-off-by: Mohammad Athari Bin Ismail
> > <mohammad.athari.ismail@xxxxxxxxx>
> > ---
> > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the stable kernel
> tree. Please read:
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
>
> </formletter>

I'm sorry. Will follow the correct process. Thank you for the advice.

-Athari-