Re: [PATCH] sched/uclamp: Fix getting unreasonable ucalmp_max when rq is idle

[Valentin Schneider]

On 30/06/21 09:24, Xuewen Yan wrote:
> On Tue, Jun 29, 2021 at 9:50 PM Valentin Schneider
> <valentin.schneider@xxxxxxx> wrote:
>> +       min_util = max_t(unsigned long, min_util, READ_ONCE(rq->uclamp[UCLAMP_MIN].value));
>> +       max_util = max_t(unsigned long, max_util, READ_ONCE(rq->uclamp[UCLAMP_MAX].value));
>
> Is it necessary to use max_t here? although it is not the main problem...
>

I got comparison warnings when using a regular max() - the RQ clamp values
are unsigned int, whereas the local variable is unsigned long.

>> +out:
>>         /*
>>          * Since CPU's {min,max}_util clamps are MAX aggregated considering
>>          * RUNNABLE tasks with _different_ clamps, we can end up with an
>
> Thanks!
> xuewen