Re: [PATCH v3 3/3] spi:amd:Fix for compilation error for non X86 platforms.

[Shah, Nehal-bakulchandra]

Hi Mark
On 6/30/2021 6:17 PM, Mark Brown wrote:
> On Wed, Jun 30, 2021 at 05:34:25PM +0530, Nehal Bakulchandra Shah wrote:
>
> > Update the KConfig with dependency for ACPI as driver is only
> > supported for x86 platform. This fixes the compilation error
> > reported by kernel test robot.
> If one of the earlier patches in the series fails to build you need to
> fix that patch so you don't break bisection or cause people to spend
> time finding errors in the earlier patches you fix later.
>
> In any case this doesn't do what the commit log says, ACPI is supported
> on at least arm64 so if you genuinely need an x86 dependency ACPI isn't
> going to cut it and COMPILE_TEST means the driver will still be built on
> everything.  I don't recall anything from 0day that looked like it was
> anything to do with dependencies though.
so now should i RESEND this patch with suggested changes,i.e removing 
ACPI depedency
change and removing COMPILE_TEST?
Thanks
Nehal