Re: [PATCH] regulator: palmas: set supply_name after registering the regulator

[Mark Brown]

On Wed, Jun 30, 2021 at 04:43:14PM +0200, H. Nikolaus Schaller wrote:
> > Am 30.06.2021 um 15:04 schrieb Mark Brown <broonie@xxxxxxxxxx>:
> > On Wed, Jun 30, 2021 at 02:29:02PM +0200, H. Nikolaus Schaller wrote:
> >>> Am 30.06.2021 um 14:13 schrieb Mark Brown <broonie@xxxxxxxxxx>:

> >  It's a super weird hardware design if the DT is accurate,

> I get the impression that the vdds_1v8_main is in the DT (omap5-board-common.dtsi)
> only as an alias for smps7. Maybe to get more flexibility in overwriting
> in board files? I.e. replace the power controller without having a fixed
> definition of smps7 elsewhere.

It doesn't seem to have any effect in software and the input is
specified at the same voltage as the output which would be very unusual.
No idea why you'd do any aliasing, you can already name the regulators
with DT handles and with user visible strings.

> Looking into the schematics of the OMAP5432EVM or the Pyra handheld does
> not reveal a physical regulator. It is just that the output signal of
> smps7 is called "VDDS_1v8_MAIN".

It could be something incorrectly factored out of some early prototypes
or something.

> Therefore, a completely different approach could be to remove fixedregulator-vdds_1v8_main
> and replace by smps7_reg.

If there's no physical regulator on the board then that is indeed a DT
bug, the fixed regulator just shouldn't be there.

> But is changing the DT the right solution if the Palmas and Fixed regulator
> drivers can't handle the untouched DT which is logically correct (not physically)?

Well, it's a good thing to do anyway since the DT is supposed to
accurately reflect the hardware.  Like I say splitting the LDOs and
SMPSs can also be done independently and should separately resolve the
issue.

> > it's hard to see how it's not going to be hurting efficiency.

> Well, I think the regulators are enabled only once during boot so nobody
> notices an issue.

When I say having an extra regulator in there hurts efficiency I'm
saying that the power losses from regulation will be increased as
there's more of it happening.

Attachment: signature.asc
Description: PGP signature