Re: [PATCH -next] drm: vmwgfx: add header file for ttm_range_manager

From: Zack Rusin
Date: Wed Jun 30 2021 - 16:36:40 EST




> On Jun 30, 2021, at 16:32, Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> Add a header file for ttm_range_manager function prototypes to
> eliminate build errors:
>
> ../drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function ‘vmw_vram_manager_init’:
> ../drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:678:8: error: implicit declaration of function ‘ttm_range_man_init’; did you mean ‘ttm_tt_mgr_init’? [-Werror=implicit-function-declaration]
> ret = ttm_range_man_init(&dev_priv->bdev, TTM_PL_VRAM, false,
> ../drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function ‘vmw_vram_manager_fini’:
> ../drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:690:2: error: implicit declaration of function ‘ttm_range_man_fini’; did you mean ‘ttm_pool_mgr_fini’? [-Werror=implicit-function-declaration]
> ttm_range_man_fini(&dev_priv->bdev, TTM_PL_VRAM);
>
> Fixes: 9c3006a4cc1b ("drm/ttm: remove available_caching")
> Fixes: a343160235f5 ("drm/vmwgfx/ttm: fix the non-THP cleanup path.")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: "VMware Graphics" <linux-graphics-maintainer@xxxxxxxxxx>
> Cc: Roland Scheidegger <sroland@xxxxxxxxxx>
> Cc: Zack Rusin <zackr@xxxxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: Dave Airlie <airlied@xxxxxxxxxx>
> Cc: Christian König <christian.koenig@xxxxxxx>

Thank you. That change has been part of drm-misc for a few weeks now:
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=352a81b71ea0a3ce8f929aa60afe369d738a0c6a
I think it should be part of the next merge of drm-misc to linux-next. If not I’ll port it to drm-misc-fixes.

z